Changeset 150

Timestamp:

31.03.2008 01:22:35 (9 months ago)

Author:

poillubo

Message:

* when a client is withdrawn, all the transient windows are withdrawn too

(recommanded behavior in the ICCCM?)

* new option map_transients in Client.map
* added a test in Client.hide in order not to hide an already hidden window

(if Client.hide happens twice, 2 tempory hooks get added, and this should not happen)

Files:

• trunk/pycawm/client.py (modified) (7 diffs)

trunk/pycawm/client.py

@@ -370 +370 @@
-            title_bar_pixmap.free()
-
-
+, map_transients=False
-        if (self.states.icccm_state == self.just_reparented or
-            self.states.icccm_state == self.normal):
@@ -378 +378 @@
-            self.title_bar.map()
-            self.window.map()
+            # get rid of the just_reparented state
+            self.states.icccm_state == self.normal
-        # unmapped client getting a map...
-        elif (self.parent != self.screen.root and
@@ -387 +389 @@
-        self.window.set_wm_state(state=Xutil.NormalState, icon=0)
-        self.update_frame()
+
+        if map_transients:
+            for transient in self.transient_clients:
+                transient.map()
-
-    def fake_reparent(self):
@@ -491 +497 @@
-            self.parent.unmap()
-            self.title_bar.unmap()
+            # will generate a BadWindow error if the window is already destroyed
+            self.window.unmap(onerror=self.error_handler)
-            self.states.focused = False
-            self.make_last()
-            self.wm.set_new_focused_client()
+
+        for transient in self.transient_clients:
+            transient.withdraw()
-
-    def manage(self, new_window=True):
@@ -915 +926 @@
-
-    def hide(self):
+        if self.is_hidden():
+            return
+
-        # do not generate dummy enternotify events, unmap the parent first
-        self.parent.unmap()
@@ -936 +950 @@
-            return
-
+        self.hide()
-        self.states.icccm_state = self.iconified
-        self.window.set_wm_state(state=Xutil.IconicState, icon=0)
-        self.hide()
-        for transient in self.transient_clients:
-
-
+
-
-    def uniconify(self):
@@ -947 +960 @@
-            return
-
+        self.unhide()
-        self.states.icccm_state = self.normal
-        self.window.set_wm_state(state=Xutil.NormalState, icon=0)
-        self.unhide()
-        for transient in self.transient_clients:
-            transient.uniconify()